Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Gmail Node): Add tests for Gmail node v1 (no-changelog) #12461

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Jan 6, 2025

Summary

Add tests added in #12278 for v2, to v1 node

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2205/add-tests-to-gmail-node-v1

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

}
},
{
"parameters": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no add label operation for V1 it is under a different resource Message Label

},
{
"parameters": {
"operation": "removeLabels",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with this one, it is under a different resource Message Label

},
{
"parameters": {
"operation": "markAsUnread",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this operation also does not exist. for v1

},
{
"parameters": {
"operation": "markAsRead",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this operation does not exist for v1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no thread resource for v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants